Beagle SCM

URI-013: URI hygiene — route ALL URI parse/compose through the URI class (retire manual indexOf/slice/split parsing + string-concat construction)

A READ-ONLY audit of the JS tree found URIs parsed and composed BY HAND across 30 production files: Category A (manual PARSING — indexOf(":")/slice/split/regex to pull scheme/authority/path/query/fragment) and Category B (manual CONSTRUCTION — scheme + ":" + … string-concat). The canonical helpers themselves offend: shared/nav.js navUri concatenates and navAuthorize hand-splits — the helper that should BE the fix. Rule: ONLY the URI class (new URI / uri._parse / URI.make / .toString) and the nav/refKey helpers (built ON it) may parse or compose a URI. This is a behavior-PRESERVING refactor — the existing suite (esp. plain/tlv byte-parity) is the safety net. Highest value: views/status/status.js:322 bypasses navUri (the scope-leak class URI-012 fixed on the RESOLVE side, still open on the BAKE side), the nav helpers hand-roll, and 39 ?branch#sha refs-key concats want ONE shared refKey(). Method Issues.

Input

Context

• Findings from the URI hand-parsing audit (read-only scan): two categories — A (manual parse: indexOf/slice/split/regex over a URI) and B (manual construct: string-concat instead of URI.make). ~30 production files; the idioms CLUSTER (not scattered).
• The canonical helpers hand-roll: shared/nav.js:13 navUri (scheme + ":" + a + (a&&path?"/":"") + path) and :24-29 navAuthorize (indexOf(":") + slice + rest.slice(0,2)==="//"). Fix these FIRST so every caller can route through them.
• Scope-leak class: views/status/status.js:322 bakes ("diff:"|"cat:") + navPath bypassing navUri, so click-targets DROP the //authority — the URI-012 bug on the BAKE side (URI-012 fixed only the RESOLVE side).
• Systemic idioms: 10 read views strip <scheme>: by slice then re-prepend + re-parse (A9/B5/B6 — collapses to one uri._parse); 39 sites concat ?branch#sha / path#sha refs-log keys (B10 — one refKey()).
• A URI-class GAP (NOT a violation to "fix" by more hand-parsing): recovering slot-present-but-empty (?/# presence) via indexOf because .query/.fragment collapse undefined vs "" — see URI-009; leave + link, needs a binding API.

Goals

• No production JS parses or composes a URI by hand: every scheme/authority/path/query/fragment READ comes off new URI/uri._parse; every URI BUILT via URI.make/.toString or a nav/refKey helper.
• shared/nav.js navUri + navAuthorize reimplemented on the URI class, idempotent, BYTE-IDENTICAL output.
• status.js emits click-targets via navlib.navUri (authority-scoped) — closes the bake-side scope leak (twin of URI-012).
• ONE shared refKey(branch, sha) (URI.make-based) replaces the ~39 ?b#sha concats.
• Behavior-PRESERVING: the whole suite stays green; plain/tlv paths stay byte-for-byte identical.

Constraints

• Refactor ONLY — no behavior change. Repro = the existing suite stays green (byte-parity for plain/tlv). Do NOT add features or touch test assertions.
• Allowed API only: URI.make / uri._parse / new URI / .toString + shared/nav.js. No new hand-parsing anywhere.
• The A8 / URI-009 slot-presence workaround stays UNTIL the URI binding exposes presence — do NOT replace it with more indexOf; leave it, link URI-009.
• Byte-parity: URI.make must reproduce the exact old string (leading /, empty ?/#, empty authority) — verify against plain/tlv parity tests.
• Parallel workers share ONE worktree with DISJOINT file sets; workers EDIT ONLY — the orchestrator runs the single build + ctest -j16 + commit (no concurrent ninja/jab in the shared wt) (Issues).

WIP

Design decisions

• Fix the helpers FIRST (nav.js) + add refKey so the systemic clusters collapse into helper calls, not open-coded URI.make repeated 39×.
• Partition the work by DISJOINT files into parallel clusters (the TODO Wn list); each cluster is behavior-preserving and independently checkable via the full suite.
• Each cluster may use URI.make DIRECTLY to avoid a hard dep on W1's helper landing first; consolidate to refKey/navUri in a follow-up sweep if needed.

TODOs

• W1 helpers/foundation: shared/nav.js (navUri B0, navAuthorize A1), shared/hunkrows.js (A3), view/bro.js (A2 statusURI), shared/store.js (B10 keyURI + DEFINE refKey).
• W2 bake-side views: views/status/status.js (B1:322 via navUri, B2 joinPrefix, B10 294/296/332), views/diff/diff.js (B9:375 hunk-uri, B5:426 re-scheme).
• W3 read projectors: views/{cat,blob,sha1,tree,size,type,log,commit,spot} strip/re-scheme dance (A9/B5/B6); LEAVE A8 presence-scan, link URI-009.
• W4 verbs refs-key: verbs/{get,put,post,patch,head} ?b#sha concats (B10) + head A5/B4, put A6 → URI.make/refKey.
• W5 core/shared: core/loop.js (A10/A11/B7), core/discover.js (B8), shared/wire.js (A4), shared/submount.js (A7/B3), shared/ingest.js (B10).
• Orchestrator: one build + ctest -j16 (byte-parity green) + commit; final grep proves zero remaining Cat-A/Cat-B in production JS (except the URI-009-gated A8 sites).

Blockers and bummers

• URI-009 slot-presence (undefined vs empty) blocks fully retiring the A8 indexOf("?"|"#") presence scans — leave them, linked.
• refKey adoption is a soft dep (W4/W5 want W1's helper); mitigate by using URI.make directly, consolidate later.
• Byte-parity risk: URI.make edge cases (empty authority, empty ?, path leading slash) MUST match the old concat exactly — parity tests are the gate.

Outcome

• OPEN — filed 2026-07-04 from the URI hand-parsing audit; the systemic cleanup behind URI-012's single-site resolve fix. Retires manual URI parse/compose across the JS tree in favor of the URI class + nav/refKey helpers.